bugtraq:message is always appended/prepended

Oh, and of course:
If both the bugtraq:message and bugtraq:logregex properties are set,
logregex takes precedence.

This tells me tortoise will first try to use logregex on the commit
message, and use the found bug id if any. If there is no match, it will use
the entered bug id. If neither are present, no bug id is added at all.

I guess I have to correct myself here:

A testing repository with bugtraq:append "false" and bugtraq:message
"FS#%BUGID%" lets me commit without problems.
A live repository that has additional properties bugtraq:url "http..." and
bugtraq:logregex "[Ff][Ss]#\s*(\d+)" does not allow a commit.

My guess is that logregex is used to validate the input into the Bug ID
Field shown in the small commit window.
From my point of view, this behaviour is not correct. url and logregex are
used for representation, in the log window for example. To my knowledge,
they are not used to validate the input of the bug id field, but to parse a
bug id from the log message.

From the TortoiseSVN documentation
(http://tortoisesvn.net/docs/release/TortoiseSVN_sk/tsvn-dug-bugtracker.html):
Issue Numbers Using Regular Expressions
In the approach with regular expressions, TortoiseSVN _doesn't show a
separate input field but marks the part of the log message the user enters_
which is recognized by the issue tracker. This is done while the user
writes the log message. This also means that the bug ID can be anywhere
inside a log message! This method is much more flexible, and is the one
used by the TortoiseSVN project itself.

I just tested 1.6.0.3 due to the feature request I posted in pst2263, and
it seems the bugtraq functions seem to work properly now.

Thank you for the preliminary version, and sorry for the late reply, I was
on vacation for two weeks.

Committing files with commit-message only now correctly only sends the
commit message, and no empty "FS#" prefix.

However, it seems there is still some problems with the new version.
Attempting to commit a file with bug-id yields an error:
"Wrong Bug-ID format. Please correct Bug-ID and try again."
1) Pending Checkins, leave Comment empty
2) Provide a commit message, fill in Bug-ID "1234"
3) Provide a commit message, fill in commit message "this is a test".
With previously mentioned bugtraq properties, those steps yield the error
message.
attempting to enter "FS#1234" as Bug-ID yields "Bug-ID must contain only
digits and ','."

Sounds great, looking forward to the fix!

I just noticed something else.
When setting a Bug-ID for a commit that contains added files, two commit
messages are generated:
1) FileX added - Bug-ID 1234, FS#1234 commit message
2) FileX commited - Bug-ID , FS# commit message

The second commit does not have the Bug-ID informations set.

Thanks for the Info, but I got this set to "never" at the moment.
Whenever I commit to a repository with those bugtraq properties and leave
the "Comment" of the "Pending Checkins" window empty, the small window in
the attachment appears.

1) Leaving both "Comment" and the message in the window empty (this warns
me about the message being empty), the committed Log Entry is "FS# ".
2) Leaving "Comment" empty, but supplying something in the small window,
without specifying a Bug-ID, the committed log entry is "FS# " followed by
the entered text.
3) Filling in "Comment" does not open the small window, but this does not
allow for Bug-IDs to be entered either. The committed Log Entry is "FS# "
followed by the text.

The only change "always" brings to above points is the fact that the small
window is always shown, even when a "Comment" was supplied already.

Since you logged this feature for the next release, I'd like to ask for a
similar input field in the "Pending Checkins" window. TortoiseSVN for
example only shows the "Bug-ID" textbox in the top right corner when
bugtraq:message is defined - a similar behavior here would be neat.
Also, if this feature was added, I'd like to ask for the "When should
commit messages be explicitly requested" option to stick to "never", and
really never ask for a log message. If I wanted to supply one (with or
without Bug-ID), I would have done so using the Comments button.

When committing to a repository with bugtraq Properties set, the
bugtraq:message is always appended (or prepended if bugtraq:append is set
to false), regardless of whether a Bug-ID is entered in the Popup-Window or
not.

This yields a series of Log Messages as follows:

Rev. | Author | Bug-ID | Message
1004 | me | | FS#
1003 | me | | FS# no message
1002 | me | | FS#
1001 | me | | FS# test without Bug-ID
1000 | me | 1234 | FS#1234 Fixed bug 1234

with the set of properties:
bugtraq:url http://flyspray.internal/index.php?do=details&task_id=%BUGID%
bugtraq:message FS#%BUGID%
bugtraq:append false
bugtraq:logregex [Ff][Ss]#\s*(\d+)

Committing files using for example TortoiseSVN only appends/prepends the
message when a Bug-ID is entered along with the commit message.

Visual Studio 2008 SP1 on Windows XP Professional SP3.
PushOK SVNSCC v1.5.1.2; svn, version 1.5.1 (r32289) compiled Feb 27 2009,
13:06:48
TortoiseSVN 1.5.5.14361 (in case it matters)
Apache/2.2.3 with mod_svn 1.5.1; Subversion version 1.5.1 (r32289)